Skip to content

Conversation

eamodio
Copy link
Member

@eamodio eamodio commented Jan 7, 2025

  • Refactors merge/rebase status into a unified paused operation status
    • Adds cherry-pick and revert statuses
    • Improves performance of detecting a paused operation
  • Adds abort / continue actions & basic error handling

@eamodio eamodio requested a review from Copilot January 7, 2025 07:40
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 23 out of 38 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • src/git/models/merge.ts: Evaluated as low risk
  • src/git/models/rebase.ts: Evaluated as low risk
  • src/constants.views.ts: Evaluated as low risk
  • src/views/nodes/fileRevisionAsCommitNode.ts: Evaluated as low risk
  • src/git/errors.ts: Evaluated as low risk
  • src/views/nodes/fileHistoryNode.ts: Evaluated as low risk
  • src/views/nodes/branchNode.ts: Evaluated as low risk
  • src/views/branchesView.ts: Evaluated as low risk
  • src/views/nodes/mergeConflictCurrentChangesNode.ts: Evaluated as low risk
  • src/plus/integrations/providers/github/githubGitProvider.ts: Evaluated as low risk
  • src/env/node/git/localGitProvider.ts: Evaluated as low risk
  • src/trackers/documentTracker.ts: Evaluated as low risk
  • src/git/gitProvider.ts: Evaluated as low risk
  • src/git/gitProviderService.ts: Evaluated as low risk
  • src/views/nodes/abstract/viewNode.ts: Evaluated as low risk
Comments suppressed due to low confidence (2)

src/env/node/git/git.ts:79

  • [nitpick] The updated error message for 'changesWouldBeOverwritten' should be reviewed to ensure it is clear and helpful.
changesWouldBeOverwritten: /Your local changes to the following files would be overwritten|Your local changes would be overwritten/i,

src/env/node/git/git.ts:98

  • [nitpick] The newly introduced error message for 'noPausedOperation' should be reviewed to ensure it is clear and helpful.
noPausedOperation: /no merge (?:in progress|to abort)|no cherry-pick(?: or revert)? in progress|no rebase in progress/i,

@eamodio eamodio modified the milestones: 16.3-patch, 16.2 Jan 7, 2025
 - Unifies into paused operation status
 - Adds cherry-pick and revert statuses
 - Improves performance of detecting a paused operation
Adds abort & continue actions (wip)
Moves paused operation status strings into utils
@eamodio eamodio force-pushed the feature/paused-op-status branch from 552f0d1 to ef478e4 Compare January 8, 2025 00:03
@eamodio eamodio marked this pull request as ready for review January 8, 2025 00:05
@eamodio eamodio requested a review from d13 January 8, 2025 00:05
@eamodio eamodio unassigned d13 Jan 8, 2025
@eamodio eamodio merged commit 175807c into main Jan 8, 2025
4 checks passed
Copy link
Member

@d13 d13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was reviewed and approved by me prior to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants